Conversation
clangenb
force-pushed
the
cl/polkadot-v0.9.39
branch
from
011e2bc to
6968f0a
Compare
clangenb
requested review from
OverOrion and
coax1d
and removed request for
coax1d
clangenb
commented
May 16, 2023
| "pallet-child-bounties/std", | ||
| "pallet-collective/std", | ||
| "pallet-democracy/std", | ||
| "pallet-randomness-collective-flip/std", |
Contributor
Author
There was a problem hiding this comment.
Doesn't exist anymore, but we did not use the pallet anyhow.
OverOrion
reviewed
May 17, 2023
OverOrion
approved these changes
May 17, 2023
Contributor
OverOrion
left a comment
OverOrion
left a comment
There was a problem hiding this comment.
LGTM, thanks for this!
brenzi
reviewed
Jan 26, 2024
| use xcm_transactor_primitives::*; | ||
|
|
||
| const fn teer_general_key() -> Junction { | ||
| const TEER_KEY: [u8; 32] = *b"TEER0000000000000000000000000000"; |
Collaborator
There was a problem hiding this comment.
@clangenb we found the cause of broken XCM ;-)
char '0' is hex 0x30, but should be 0x00
Contributor
Author
There was a problem hiding this comment.
omg, sorry for that.
Collaborator
There was a problem hiding this comment.
not blaming, just documenting ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains the change to XCMV3: paritytech/cumulus#697.
The XCM migration is based upon https://github.com/PureStake/moonbeam/pull/2145/files.
Tests:
Follow-up tasks: